DRILL-7412: Minor unit test improvements #1876
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many tests intentionally trigger errors. A debug-only log setting sent those errors to stdout. The resulting stack dumps simply cluttered the test output, so disabled error output to the console. Drill can apply bounds checks to vectors. Tests run via Maven enable bounds checking. Now, bounds checking is also enabled in "debug mode" (when assertions are enabled, as in an IDE.) Drill contains two test frameworks. The older BaseTestQuery was marked as deprecated, but many tests still use it and are unlikely to be changed soon. So, removed the deprecated marker to reduce the number of spurious warnings. Also includes a number of minor clean-ups.
|
+1 |
xiangt920
pushed a commit
to xiangt920/drill
that referenced
this pull request
Dec 26, 2019
Many tests intentionally trigger errors. A debug-only log setting sent those errors to stdout. The resulting stack dumps simply cluttered the test output, so disabled error output to the console. Drill can apply bounds checks to vectors. Tests run via Maven enable bounds checking. Now, bounds checking is also enabled in "debug mode" (when assertions are enabled, as in an IDE.) Drill contains two test frameworks. The older BaseTestQuery was marked as deprecated, but many tests still use it and are unlikely to be changed soon. So, removed the deprecated marker to reduce the number of spurious warnings. Also includes a number of minor clean-ups. closes apache#1876
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many tests intentionally trigger errors. A debug-only log setting
sent those errors to stdout. The resulting stack dumps simply cluttered
the test output, so disabled error output to the console.
Drill can apply bounds checks to vectors. Tests run via Maven
enable bounds checking. Now, bounds checking is also enabled in
"debug mode" (when assertions are enabled, as in an IDE.)
Drill contains two test frameworks. The older BaseTestQuery was
marked as deprecated, but many tests still use it and are unlikely
to be changed soon. So, removed the deprecated marker to reduce the
number of spurious warnings.
Also includes a number of minor clean-ups.