DRILL-7413: Test and fix scan operator vectors #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: This PR builds on DRILL-7403, which is not yet merged. So, the commits from DRILL-7403 appear here as well. For review, just focus on the DRILL-7413 commit. I will rebase to include just that commit once DRILL-7403 is merged. |
|
LGTM, +1 |
|
@paul-rogers please resolve the conflicts. |
paul-rogers
force-pushed
the
DRILL-7413
branch
3 times, most recently
from
53c1ef0
to
40328e7
Compare
Enables vector validation tests for the ScanBatch and all EasyFormat plugins. Fixes a bug in scan batch that failed to set the record count in the output container. Fixes a number of formatting and other issues found while adding the tests.
paul-rogers
force-pushed
the
DRILL-7413
branch
from
40328e7
to
9d63181
Compare
|
Rebased on master, resolved conflicts, and reran tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables vector validation tests for the ScanBatch and all EasyFormat plugins. Fixes a bug in scan batch that failed to set the record count in the output container.
Fixes a number of formatting and other issues found while adding the tests.