-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRILL-8235: Add Storage Plugin for Google Sheets #2585
Conversation
...lesheets/src/main/java/org/apache/drill/exec/store/googlesheets/utils/GoogleSheetsUtils.java
Fixed
Show fixed
Hide fixed
This pull request introduces 12 alerts when merging 2817ce2 into 1189e25 - view on LGTM.com new alerts:
|
Nice demo vid! Before I dive in, I see that a review has been requested but the PR is also marked draft. Can I switch it over to reviewable? Btw, I like the sheet specification syntax here and it's something I wondered about when doing a bug fix on the Excel format plugin recently. But I guess Excel being a format plugin, this syntax is not available and we have to stick with the format config opt that we have? |
Thanks @jnturton !! You certainly may start reviewing if you like. I left it as draft for the moment as there is still some minor cleanup and debugging that I have to do. I don't anticipate any major changes, but I'm adding more unit tests and fixing all the LGTM / CodeQL issues and stuff like that. If you want to start... please feel free. |
This pull request introduces 4 alerts when merging 4f35184 into 1189e25 - view on LGTM.com new alerts:
|
7956cec
to
9c5389f
Compare
This pull request introduces 4 alerts when merging 9c5389f into a27eb66 - view on LGTM.com new alerts:
|
aaad02a
to
e057d01
Compare
This pull request introduces 3 alerts when merging 0862185 into af493aa - view on LGTM.com new alerts:
|
df43cda
to
0662570
Compare
@jnturton This is now ready for review. |
logical/src/main/java/org/apache/drill/common/logical/StoragePluginConfig.java
Outdated
Show resolved
Hide resolved
...sheets/src/main/java/org/apache/drill/exec/store/googlesheets/GoogleSheetsStoragePlugin.java
Outdated
Show resolved
Hide resolved
...heets/src/main/java/org/apache/drill/exec/store/googlesheets/utils/GoogleSheetsTypifier.java
Outdated
Show resolved
Hide resolved
...heets/src/main/java/org/apache/drill/exec/store/googlesheets/utils/GoogleSheetsTypifier.java
Outdated
Show resolved
Hide resolved
...lesheets/src/test/java/org/apache/drill/exec/store/googlesheets/TestGoogleSheetsQueries.java
Show resolved
Hide resolved
...lesheets/src/main/java/org/apache/drill/exec/store/googlesheets/GoogleSheetsBatchReader.java
Show resolved
Hide resolved
65140cc
to
fc22151
Compare
@jnturton Thank you very much for your review of this beast. I believe I have addressed all your comments, as well as fixed the final bugs with the writer. |
84ffd24
to
e9c2a29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the fixes. Just two minor items remaining from me.
DRILL-8235: Add Storage Plugin for Google Sheets
Description
Google Sheets is a very commonly used data source among business users. Presto and other query engines do include integrations with Google Sheets and so it would be useful for Drill to add this functionality.
The proposed plugin supports both reading and writing to Google Sheets.
Here's a quick demo:
https://www.youtube.com/watch?v=pS2FKxrluBA
This PR makes a few addition minor modifications that are not directly related to Google Sheets.
.gitignore
and removing some files which should have been ignored. Note this caused a unit test to break, so I had to rename a file to fix this.Documentation
Docs in README.
Testing
Manually tested and added unit tests.