Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRILL-5481: Allow to persist profiles in-memory only with a max capacity #834

Closed
wants to merge 1 commit into from
Closed

DRILL-5481: Allow to persist profiles in-memory only with a max capacity #834

wants to merge 1 commit into from

Conversation

kkhatua
Copy link
Contributor

@kkhatua kkhatua commented May 14, 2017

  1. Introduced an InMemoryStoreProvider with the ability to maintain a max capacity
  2. DrillbitContext now explicitly has a profileStoreProvider that, by default, re-uses the general PersistentStoreProvider, unless it is InMemory, which is when Mavenized query-parse subproject #1 is used.
  3. Cleanly separated out QueryProfileStoreContext
  4. Converted literal values to constants within ExecConstants
  5. Updated drill-module.conf for default capacity

@kkhatua
Copy link
Contributor Author

kkhatua commented May 14, 2017

@sudheeshkatkam , @ppadma
Smaller commit that addresses the in-memory profile store requirement. This one does not require me to change any existing functionality or tests. I'll close the other PR

@kkhatua kkhatua closed this May 14, 2017
@kkhatua kkhatua reopened this May 14, 2017
@kkhatua kkhatua force-pushed the DRILL-5481-alt branch 3 times, most recently from 13cf6ac to 54fba38 Compare May 15, 2017 20:23
DRILL-5481: Allow to persist profiles in-memory only with a max capacity
e35ef1f 
1. Introduced an InMemoryStoreProvider with the ability to maintain a max capacity
2. DrillbitContext now explicitly has a profileStoreProvider that, by default, re-uses the general PersistentStoreProvider, unless it is InMemory, which is when #1 is used.
2. Cleanly separated out QueryProfileStoreContext
3. Converted literal values to constants within ExecConstants
4. Updated drill-module.conf for default capacity
sudheeshkatkam
sudheeshkatkam approved these changes May 15, 2017
View reviewed changes
Copy link
Contributor

@sudheeshkatkam sudheeshkatkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

sudheeshkatkam pushed a commit to sudheeshkatkam/drill that referenced this pull request May 26, 2017
@sudheeshkatkam
DRILL-5481: Allow to persist profiles in-memory only with a max capacity
7f7038a 
1. Introduced an InMemoryStoreProvider with the ability to maintain a max capacity
2. DrillbitContext now explicitly has a profileStoreProvider that, by default, re-uses the general PersistentStoreProvider, unless it is InMemory, which is when apache#1 is used.
2. Cleanly separated out QueryProfileStoreContext
3. Converted literal values to constants within ExecConstants
4. Updated drill-module.conf for default capacity

closes apache#834
@asfgit asfgit closed this in 9ba4af8 Jun 3, 2017
@kkhatua kkhatua deleted the DRILL-5481-alt branch February 26, 2018 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudheeshkatkam sudheeshkatkam sudheeshkatkam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kkhatua @sudheeshkatkam