DRILL-5665: planner.force_2phase_aggr only overrides small inputs #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| RelNode child = call.rel(0).getInputs().get(0); | ||
| boolean smallInput = child.getRows() < settings.getSliceTarget(); | ||
| boolean smallInput = child.getRows() < settings.getSliceTarget() && |
There was a problem hiding this comment.
Overloading smallInput makes it confusing. Why not modify the if condition below to :
(... || (smallInput && !settings.isForce2phaseAggr())
This way the meaning of smallInput is not changed.
|
+1 |
arina-ielchiieva
pushed a commit
to arina-ielchiieva/drill
that referenced
this pull request
Jul 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The planner option planner.force_2phase_aggr was created for testing, but may be used someday by a customer to allow spilling (currently single phase can not spill).
That option was implemented unconditionally, thus potentially violating other checks.
The code change is to only use this option to bypass a single check -- for small input tables.