Math expressions support for missing columns. #3630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
@navis can you take a look? |
Also add SchemaEvolutionTest to help test this kind of thing. Fixes apache#3627 and includes test for apache#3625.
gianm
force-pushed
the
math-expressions-nullable
branch
from
7a4a836
to
b7ad8e9
Compare
nishantmonu51
approved these changes
Nov 1, 2016
|
@nishantmonu51 I don't think this should block on docs. The original expressions PRs and a few follow ups have gone in without docs already, and behavior has been evolving. I prefer adding docs in a separate PR when we like the behavior. |
|
Filed #3634 for that. |
fundead
pushed a commit
to fundead/druid
that referenced
this pull request
Dec 7, 2016
Also add SchemaEvolutionTest to help test this kind of thing. Fixes apache#3627 and includes test for apache#3625.
dgolitsyn
pushed a commit
to metamx/druid
that referenced
this pull request
Feb 14, 2017
Also add SchemaEvolutionTest to help test this kind of thing. Fixes apache#3627 and includes test for apache#3625.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add SchemaEvolutionTest to help test this kind of thing.
Fixes #3627.