Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Math expressions support for missing columns. #3630

Merged
merged 1 commit into from
Nov 1, 2016

Conversation

gianm
Copy link
Contributor

@gianm gianm commented Oct 31, 2016

Also add SchemaEvolutionTest to help test this kind of thing.

Fixes #3627.

@gianm gianm added this to the 0.9.3 milestone Oct 31, 2016
@fjy
Copy link
Contributor

fjy commented Oct 31, 2016

👍

@fjy
Copy link
Contributor

fjy commented Oct 31, 2016

@navis can you take a look?

Also add SchemaEvolutionTest to help test this kind of thing.

Fixes apache#3627 and includes test for apache#3625.
Copy link
Member

@nishantmonu51 nishantmonu51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. please add docs also for this.
👍, after docs are added.

@gianm
Copy link
Contributor Author

gianm commented Nov 1, 2016

@nishantmonu51 I don't think this should block on docs. The original expressions PRs and a few follow ups have gone in without docs already, and behavior has been evolving. I prefer adding docs in a separate PR when we like the behavior.

@gianm
Copy link
Contributor Author

gianm commented Nov 1, 2016

Filed #3634 for that.

@fjy fjy merged commit 45940d6 into apache:master Nov 1, 2016
@gianm gianm deleted the math-expressions-nullable branch November 2, 2016 00:27
fundead pushed a commit to fundead/druid that referenced this pull request Dec 7, 2016
Also add SchemaEvolutionTest to help test this kind of thing.

Fixes apache#3627 and includes test for apache#3625.
dgolitsyn pushed a commit to metamx/druid that referenced this pull request Feb 14, 2017
Also add SchemaEvolutionTest to help test this kind of thing.

Fixes apache#3627 and includes test for apache#3625.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants