Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make web console fast around sys.segments #10909

Merged
merged 9 commits into from
Mar 11, 2021

Conversation

vogievetsky
Copy link
Contributor

This PR does a number of things outlined below with a high level goal of making sys.segments table based views (Datasource, Segments) more performant.

image

Things done in this PR:

  • Fix issue where Segments view would try to pull in all the segments in noSQL mode
  • Improve UX around Segments view in noSQL mode
  • Make it so that the Segments view only queries for the columns that are shown, not all of them
  • Make it so that the Datasources view only queries for the columns that are shown, not all of them
  • Add UI to force the console into Coordinator mode which avoids SQL APIs

@lgtm-com
Copy link

lgtm-com bot commented Feb 19, 2021

This pull request introduces 1 alert when merging a91040d into f5bfccc - view on LGTM.com

new alerts:

  • 1 for Unused or undefined state property

@a2l007
Copy link
Contributor

a2l007 commented Feb 26, 2021

Thanks for this fix! This will definitely improve the console user experience for clusters running on restricted modes.
I haven't checked the code yet, but I did pull in this PR locally and tested it out.
Looks good but one concern I have is that it may be intuitive to disable the force mode options if the console is already in the restricted mode.
Screen Shot 2021-02-26 at 3 39 56 PM

@vogievetsky
Copy link
Contributor Author

Great point. Will do.

Copy link
Member

@clintropolis clintropolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants