Use the latest Apache DataSketches release 2.0.0 #10917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintropolis
approved these changes
Feb 25, 2021
There was a problem hiding this comment.
thanks for the update 👍
hmm, I wonder why https://github.com/apache/druid/blob/master/licenses.yaml#L3515 didn't need updated for CI to pass.
I'm not sure if https://github.com/apache/druid/blob/master/distribution/bin/check-licenses.py is actually checking the version, need to have a closer look at that script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is to bring the extensions-core/datasketches up to date with the latest post-graduation release of apache/datasketches-java-2.0.0
There were some API changes in the datasketches library. In particular, Tuple sketch classes were reorganized, and the ArrayOfDoublesSketch now has one more level in the class name. The Druid code was adjusted accordingly. No user observable behavior should be affected.