vector group by support for string expressions #11010
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expands on the structures added in #10613 to add support for grouping on string expressions in the vectorized group by engine. The key addition that makes this possible is
DictionaryBuildingSingleValueStringGroupByVectorColumnSelector
, which is the vectorized group by engine version ofDictionaryBuildingStringGroupByColumnSelectorStrategy
, and allows the vector group by engine to group on strings which are not dictionary encoded.To help showcase this, I added vectorization support to the concat operator
string1 + 'foo'
, and the concat functionconcat(string1,'-',string2,'-',long1)
.It provides a pretty decent performance increase. From the added benchmark queries:
Vectorizing additional string expressions I will save for a future PR.
Key changed/added classes in this PR
DictionaryBuildingSingleValueStringGroupByVectorColumnSelector
VectorGroupByEngine
GroupByVectorColumnProcessorFactory
VectorStringProcessors
StringOutMultiStringInVectorProcessor
This PR has: