Web console: Misc QueryView UX improvements #11158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Where is TravisCI? |
|
Oh there it is! |
clintropolis
approved these changes
Apr 24, 2021
Comment on lines
+51
to
+54
| if (e.altKey) { | ||
| if (hasMoreResults) { | ||
| onLoadMore(); | ||
| } |
There was a problem hiding this comment.
what does this do? something with limit wrapping or.. loading stuff? ... if i followed correctly back to handleLoadMore?
There was a problem hiding this comment.
If you are in the state where the auto limit wrapper is applied (sqlOuterLimit set in the context) then alt clicking here will 10x the sqlOuterLimit something that now happens when you reach the last loaded page.
So if you are in this state:
And you Alt+click the query reruns and you get:
Alt+click again and:
|
Added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a number of UX improvements to the query view ✨ based on feedback from users.
Firstly there is a cute little stopwatch ⏱️ to keep you company while the query runs:
Also added:
This PR has: