Do not log sensitive property value if JsonConfigurator fails to parse #11787
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a password or other sensitive information starting with a
{
or[
characteris specified as a property value,
JsonConfigurator
tries to parse it as a jsonobject and fails. The subsequent logs expose this sensitive information.
For example, a password starting with
[
such as belowwould produce the following logs
This PR avoids logging the property value as well as the exception message as these
might contain the sensitive information (e.g. password) which could not be parsed.
This PR has: