input type validation for datasketches hll "build" aggregator factory #12131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintropolis
reviewed
Jan 7, 2022
| @@ -71,6 +74,7 @@ protected byte getCacheTypeId() | |||
| public Aggregator factorize(final ColumnSelectorFactory columnSelectorFactory) | |||
| { | |||
| final ColumnValueSelector<Object> selector = columnSelectorFactory.makeColumnValueSelector(getFieldName()); | |||
| validateInputs(columnSelectorFactory.getColumnCapabilities(getFieldName())); | |||
There was a problem hiding this comment.
factorizeBuffer and factorizeVector should also validate their inputs
also please add tests for this stuff
Comment on lines
125
to
131
| throw new ISE( | ||
| "Invalid input type [%s] in ingestion for metric type %s, in aggregate %s for field name %s", | ||
| capabilities.asTypeString(), | ||
| HllSketchModule.BUILD_TYPE_NAME, | ||
| getName(), | ||
| getFieldName() | ||
| ); |
There was a problem hiding this comment.
this method is used at both query and ingestion time, and shouldn't mention ingestion
Suggested change
| throw new ISE( | |
| "Invalid input type [%s] in ingestion for metric type %s, in aggregate %s for field name %s", | |
| capabilities.asTypeString(), | |
| HllSketchModule.BUILD_TYPE_NAME, | |
| getName(), | |
| getFieldName() | |
| ); | |
| throw new ISE( | |
| "Invalid input [%s] of type [%s] for [%s] aggregator [%s]", | |
| getFieldName(), | |
| capabilities.asTypeString(), | |
| HllSketchModule.BUILD_TYPE_NAME, | |
| getName() | |
| ); |
| @@ -114,4 +118,19 @@ public int getMaxIntermediateSize() | |||
| return HllSketch.getMaxUpdatableSerializationBytes(getLgK(), TgtHllType.valueOf(getTgtHllType())); | |||
| } | |||
|
|
|||
| private void validateInputs(@Nullable ColumnCapabilities capabilities) | |||
| { | |||
| if (capabilities != null) { | |||
There was a problem hiding this comment.
nit: can use Types.is(capabilities, ValueType.COMPLEX) to get rid of outer if statement since it null checks
|
Addressed the changes and added junit test case |
clintropolis
changed the title
clintropolis
approved these changes
Jan 11, 2022
sachinsagare
pushed a commit
to pinterest/druid
that referenced
this pull request
Oct 28, 2022
…apache#12131) * Ingestion will fail for HLLSketchBuild instead of creating with incorrect values * Addressing review comments for HLL< updated error message introduced test case (cherry picked from commit 08fea7a)
sachinsagare
pushed a commit
to sachinsagare/druid
that referenced
this pull request
Nov 2, 2022
…apache#12131) * Ingestion will fail for HLLSketchBuild instead of creating with incorrect values * Addressing review comments for HLL< updated error message introduced test case (cherry picked from commit 08fea7a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rect values
Say we are ingesting the following dimensions for a complex data type, say hyperUnique
The ingestion will throw this error message
This PR has: