-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT : apiversion change to kubeversion #13538
Conversation
This might be a question for the larger Druid team but have we considered dropping support for Kubernetes versions prior to 1.19? All of the major cloud providers are well past 1.19 as a minimum supporter version and the open source support for 1.19 ended over a year ago. I ask because that would really simplify this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't just change the API version for Ingress because they are not compatible. Backend's format has changed and requires a service block. For example it currently looks like:
- host: {{ . | quote }}
http:
paths:
- path: {{ $ingressPath }}
backend:
serviceName: {{ $fullName }}
servicePort: http
but would need to be modified to look like:
http:
paths:
- path: {{ $ingressPath }}
backend:
service:
name: {{ $fullName }}
port:
name: http
Supporting this in a compatible way is really annoying though doable but my suggestion would be to drop support for versions prior to 1.19 and update the payload.
Also I can't remember for sure but I think pathType
might also be required in the new format as well which we should default but allow to be overridden with the new Ingress version.
@dampcake Would you accept a similar PR that dropped support for k8s < 1.19? I agree with your sentiment but the non-action on this change is really hurting anyone trying to deploy on a modern up to date kubernetes deployment. |
Created #13806 to do this in a backwards compatible way |
This pull request has been marked as stale due to 60 days of inactivity. |
This pull request/issue has been closed due to lack of activity. If you think that |
Description
Change apiVersion of ingress according to KubeVersion issue
Release note
For tips about how to write a good release note, see Release notes.
Key changed/added classes in this PR
This PR has: