Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: Update Ingress and HPA manifests to support modern K8s versions #13806

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

jwitko
Copy link
Contributor

@jwitko jwitko commented Feb 14, 2023

Fixes #13536
Obsoletes #13538

This PR should only be merged after #13783 as it is forked off of that branch due to requiring some changes made there.
The chart version bump is incremental based off of other PRs like #13796 , #13783 , #13747

Description

This helm chart is currently not compatible with some more modern K8s versions due to lack of support for updates resource API versions. This PR brings the chart more up to date by updating the Ingress and Horizontal Pod Autoscaler API versions to support newer API Versions but also maintain backwards compatibility.

Release note

Update Helm Chart Ingress and HPA manifests to support modern K8s versions


This PR has:

  • been self-reviewed.

  • added documentation for new or modified features or behaviors.

  • a release note entry in the PR description.

  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.

  • added or updated version, license, or notice information in licenses.yaml

  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.

  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.

  • added integration tests.

  • been tested in a test Druid cluster.

Copy link
Contributor

@churromorales churromorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for this, we need to support newer versions of k8s.

@jwitko
Copy link
Contributor Author

jwitko commented Mar 10, 2023

The failing test seems completely unrelated to this PR

Copy link

github-actions bot commented Feb 7, 2024

This pull request has been marked as stale due to 60 days of inactivity.
It will be closed in 4 weeks if no further activity occurs. If you think
that's incorrect or this pull request should instead be reviewed, please simply
write any comment. Even if closed, you can still revive the PR at any time or
discuss it on the dev@druid.apache.org list.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 7, 2024
@jwitko
Copy link
Contributor Author

jwitko commented Feb 7, 2024

This PR should definitely get reviewed. Please do not mark as stale

@github-actions github-actions bot removed the stale label Feb 8, 2024
@asdf2014
Copy link
Member

@jwitko Thanks for your contribution. As mentioned in PR #15904, we have migrated the Helm Chart to a new repository, you are welcome to raise up new PR there and we can maintain the Druid Helm Chart together in new repository. And this PR will closed soon. Thank you again for your understanding and collaboration.

Copy link

This pull request has been marked as stale due to 60 days of inactivity.
It will be closed in 4 weeks if no further activity occurs. If you think
that's incorrect or this pull request should instead be reviewed, please simply
write any comment. Even if closed, you can still revive the PR at any time or
discuss it on the dev@druid.apache.org list.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change KubeVersion Ingress apiVersion
4 participants