New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: Update Ingress and HPA manifests to support modern K8s versions #13806
base: master
Are you sure you want to change the base?
helm: Update Ingress and HPA manifests to support modern K8s versions #13806
Conversation
…ployment-on-k8s-1-25
…ployment-on-k8s-1-25
…ployment-on-k8s-1-25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for this, we need to support newer versions of k8s.
…ployment-on-k8s-1-25-part2
The failing test seems completely unrelated to this PR |
…ployment-on-k8s-1-25-part2
…ployment-on-k8s-1-25-part2
This pull request has been marked as stale due to 60 days of inactivity. |
This PR should definitely get reviewed. Please do not mark as stale |
@jwitko Thanks for your contribution. As mentioned in PR #15904, we have migrated the Helm Chart to a new repository, you are welcome to raise up new PR there and we can maintain the Druid Helm Chart together in new repository. And this PR will closed soon. Thank you again for your understanding and collaboration. |
This pull request has been marked as stale due to 60 days of inactivity. |
Fixes #13536
Obsoletes #13538
This PR should only be merged after #13783 as it is forked off of that branch due to requiring some changes made there.
The chart version bump is incremental based off of other PRs like #13796 , #13783 , #13747
Description
This helm chart is currently not compatible with some more modern K8s versions due to lack of support for updates resource API versions. This PR brings the chart more up to date by updating the Ingress and Horizontal Pod Autoscaler API versions to support newer API Versions but also maintain backwards compatibility.
Release note
Update Helm Chart Ingress and HPA manifests to support modern K8s versions
This PR has:
been self-reviewed.
added documentation for new or modified features or behaviors.
a release note entry in the PR description.
added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
added or updated version, license, or notice information in licenses.yaml
added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
added integration tests.
been tested in a test Druid cluster.