Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: Fix PDB apiVersion to allow K8s 1.25+ deployment #13783

Merged

Conversation

jwitko
Copy link
Contributor

@jwitko jwitko commented Feb 9, 2023

Description

The Apache Druid helm chart can not currently be deployed on Kubernetes v1.25+ with PodDisruptionBudgets enabled. The API Version being used (policy/v1beta1) has been removed in Kubernetes 1.25. This PR allows for the updated policy version when helm can determine that the cluster version is >1.21 (when the API was deprecated). It also paves the way for a place and style to do other changes of this nature.

Release note

Fix broken helm chart deployments using PodDisruptionBudget for Kubernetes 1.25+

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@a2l007 a2l007 added Helm Chart https://github.com/apache/druid/tree/master/helm/druid Kubernetes labels Feb 14, 2023
@abhishekagarwal87 abhishekagarwal87 merged commit 355cdbe into apache:master Feb 15, 2023
@jwitko jwitko deleted the helm/fix-chart-deployment-on-k8s-1-25 branch February 15, 2023 05:55
@tejaswini-imply
Copy link
Member

This is causing packaging check to fail.

@clintropolis
Copy link
Member

This is causing packaging check to fail.

fix #13810

@abhishekagarwal87
Copy link
Contributor

I also created a PR - #13811

@clintropolis
Copy link
Member

clintropolis commented Feb 15, 2023

I also created a PR - #13811

oops, missed that one, approved yours

@clintropolis
Copy link
Member

oh i guess I didn't miss it, mine was first 😅 , whatever, still closed mine and approved yours

@jwitko
Copy link
Contributor Author

jwitko commented Feb 15, 2023

Thanks @clintropolis @abhishekagarwal87 , sorry for missing that.

@clintropolis clintropolis added this to the 26.0 milestone Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Helm Chart https://github.com/apache/druid/tree/master/helm/druid Kubernetes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants