New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: Fix PDB apiVersion to allow K8s 1.25+ deployment #13783
Merged
abhishekagarwal87
merged 4 commits into
apache:master
from
jwitko:helm/fix-chart-deployment-on-k8s-1-25
Feb 15, 2023
Merged
helm: Fix PDB apiVersion to allow K8s 1.25+ deployment #13783
abhishekagarwal87
merged 4 commits into
apache:master
from
jwitko:helm/fix-chart-deployment-on-k8s-1-25
Feb 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishekagarwal87
approved these changes
Feb 10, 2023
…ployment-on-k8s-1-25
…ployment-on-k8s-1-25
8 tasks
churromorales
approved these changes
Feb 13, 2023
a2l007
added
Helm Chart
https://github.com/apache/druid/tree/master/helm/druid
Kubernetes
labels
Feb 14, 2023
…ployment-on-k8s-1-25
9 tasks
This is causing packaging check to fail. |
fix #13810 |
I also created a PR - #13811 |
oops, missed that one, approved yours |
oh i guess I didn't miss it, mine was first 😅 , whatever, still closed mine and approved yours |
Thanks @clintropolis @abhishekagarwal87 , sorry for missing that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Apache Druid helm chart can not currently be deployed on Kubernetes v1.25+ with PodDisruptionBudgets enabled. The API Version being used (
policy/v1beta1
) has been removed in Kubernetes 1.25. This PR allows for the updated policy version when helm can determine that the cluster version is>1.21
(when the API was deprecated). It also paves the way for a place and style to do other changes of this nature.Release note
Fix broken helm chart deployments using PodDisruptionBudget for Kubernetes 1.25+
This PR has: