Fix default value for globalIngestionHeapLimitBytes #16654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfaraz
reviewed
Jun 26, 2024
Co-authored-by: Kashif Faraz <kashif.faraz@gmail.com>
kfaraz
approved these changes
Jun 26, 2024
|
@kfaraz thanks for the review. There appears to be an issue with the web-check GHA downloading node, would you mind rerunning it to see if that resolves it? |
|
Thanks for your first contribution to Apache Druid, @hevansDev ! |
|
Thanks @kfaraz! Hopefully the first of many! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8255
Description
Updated the default value of
globalIngestionHeapLimitBytesto the correct value1/6th of the JVM heapThis PR has: