Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serde for ColumnBasedRowsAndColumns to fix window queries without group by #16658

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Add serde for ColumnBasedRowsAndColumns to fix window queries without group by #16658

wants to merge 18 commits into from

Conversation

sreemanamala
Copy link
Contributor

@sreemanamala sreemanamala commented Jun 26, 2024 •
edited

Description

Register a Ser-De for RowsAndColumns so that the window operator query running on leaf operators would be transferred properly on the wire. Would fix the empty response given by window queries without group by on the native engine.

Key changed/added classes in this PR
  • RowsAndColumns
  • FrameRowsAndColumns
  • DruidDefaultSerializersModule

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@sreemanamala sreemanamala marked this pull request as draft June 26, 2024 05:37
@sreemanamala sreemanamala marked this pull request as ready for review June 26, 2024 15:00
kgyrtkirk
kgyrtkirk reviewed Jun 28, 2024
View reviewed changes
sql/src/test/resources/calcite/tests/window/wikipediaFramedAggregations.sqlTest
@@ -2,7 +2,7 @@ type: "operatorValidation"

sql: |
SELECT
countryIsoCode,
countryIsoCode,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace

@sreemanamala sreemanamala reopened this Jul 22, 2024
@sreemanamala sreemanamala marked this pull request as draft July 22, 2024 04:59
@sreemanamala sreemanamala marked this pull request as ready for review July 25, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgyrtkirk kgyrtkirk Awaiting requested review from kgyrtkirk

Assignees
No one assigned
Labels
Area - Querying
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sreemanamala @kgyrtkirk