Fixes for multiple issues #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just generally, I thinkg Sixtus has a point about being able to cherry-pick fixes. We haven't been too good about that stuff until now, but we should definitely try to get better about it. |
| @@ -288,6 +288,10 @@ public void childEvent(CuratorFramework client, PathChildrenCacheEvent event) th | |||
|
|
|||
| final String inventoryKey = ZKPaths.getNodeFromPath(child.getPath()); | |||
|
|
|||
| if (inventoryKey == null) { | |||
There was a problem hiding this comment.
I don't believe that ZKPaths.getNodeFromPath() can return null, which bug is this fixing?
This was referenced Jul 23, 2013
suneet-s
referenced
this pull request
in suneet-s/druid
Aug 12, 2020
…plicit null valued rows (apache#10248) (#175) * fix bug with realtime expressions on sparse string columns * fix test * add comment back * push capabilities for dimensions to dimension indexers since they know things * style * style * fixes * getting a bit carried away * missed one * fix it * benchmark build fix * review stuffs * javadoc and comments * add comment * more strict check * fix missed usaged of impl instead of interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #174, #172, #162, #159, #146, #145, #90