EC2 autoscaler: avoid hitting aws filter limits #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -45,6 +46,7 @@ | |||
| public class EC2AutoScaler implements AutoScaler<EC2EnvironmentConfig> | |||
| { | |||
| private static final EmittingLogger log = new EmittingLogger(EC2AutoScaler.class); | |||
| public static final int MAX_AWS_FILTER_VALUES = 100; | |||
There was a problem hiding this comment.
Is this documented by AWS somewhere? if so can we put a comment where this came from?
There was a problem hiding this comment.
I haven't searched the docs, but the limit appears to be 200 by default.
There was a problem hiding this comment.
can we also add a comment ?
|
👍 |
1 similar comment
|
👍 |
|
hold on before merging, there's another place where we might hit this limit |
xvrl
force-pushed
the
fix-stupid-aws-limit
branch
from
0a80ba2
to
d42c8b3
Compare
|
Still 👍 |
|
ok I added comment, and fix the other filter query as well, please have a look |
|
I'm guessing there's no way to check this in a unit test is there? |
|
@drcrallen I can add a unit test, sure, |
xvrl
force-pushed
the
fix-stupid-aws-limit
branch
from
d42c8b3
to
065dfd0
Compare
xvrl
force-pushed
the
fix-stupid-aws-limit
branch
from
065dfd0
to
749ac12
Compare
|
added tests |
|
👍 |
drcrallen
added a commit
that referenced
this pull request
Nov 13, 2015
EC2 autoscaler: avoid hitting aws filter limits
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents the following error below from happening.
As a side benefit this also materialized the instanceId list, so it should reduce garbage creation.