-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More efficient SegmentMetadataQuery #2107
Conversation
{ | ||
@Nullable | ||
@Override | ||
public SegmentAnalysis apply(@Nullable SegmentAnalysis analysis) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nullable
is not valid probably. I think IDE is adding it automatically ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@himanshug Hm, yes, it was added by IDE since it was part of the Function interface definition. I've removed the @nullables.
👍 |
@himanshug Merged your other PR, resolving conflicts |
@himanshug This one's fine in that respect, the result output won't change since the query uses default analysis types |
👍 |
More efficient SegmentMetadataQuery
Addresses issue #2081
This PR makes 3 changes:
Running with a 3,450 segment test set on my laptop, the SegmentMetadataQuery takes ~16s to complete without the patch, and ~70ms with the new interval condensing behavior.