support cascade execution of extraction filters in extraction dimension spec #2209
Conversation
sirpkt
changed the title
| "type" : "extraction_cascade", | ||
| "dimension" : <dimension>, | ||
| "outputName" : <output_name>, | ||
| "extractionFns" : <array of extraction_functions> |
There was a problem hiding this comment.
what about cascadeExtractionFn? How should that be used?
edit: okay I see what this is doing
There was a problem hiding this comment.
also, can we add an example here with some sample usage?
|
I thought that CascadeExtractionFn is essential to support chaining in current ExtractionFn interface but it is inconvenient to use. |
|
I understand what you are saying @jon-wei, @drcrallen . |
|
|
||
| @JsonCreator | ||
| public CascadeExtractionFn( | ||
| @JsonProperty("extractionFns") ExtractionFn[] extractionFn) { |
There was a problem hiding this comment.
function parentheses/braces styling
|
@jon-wei @drcrallen more commentz? |
| ] | ||
| } | ||
| ``` | ||
|
|
There was a problem hiding this comment.
it would be really cool if the example showed the dimension value and the final transformed value
There was a problem hiding this comment.
@fjy I added an example.
|
👍 after commits squashed |
|
👍 after squash |
|
@sirpkt will need a CLA: http://druid.io/community/cla.html you guys may consider filling out the corporate CLA |
|
@sirpkt I can merge this after commits are squashed and CLA is signed |
sirpkt
force-pushed
the
cascade_extraction_functions
branch
from
cdcb7f2
to
238dd3b
Compare
|
commits are squashed. |
support cascade execution of extraction filters in extraction dimension spec
This PR fixes #1875