Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment the resource of JVM and the number of threads in Travis instead of default #4139

Closed
wants to merge 4 commits into from

Conversation

asdf2014
Copy link
Member

Increment the resource of JVM and the number of threads in Travis instead of default. Maybe, it could reduce the times that happen Timeout Problem even resolve the problem.

{
  "language": "java",
  "jdk": "oraclejdk8",
  "before_install": "sudo echo \"MAVEN_OPTS='-Xmx2048m -Xms1024m'\" > ~/.mavenrc",
  "script": [
    "mvn clean test -B -Pparallel-test -Dmaven.fork.count=2 -T 1C && mvn clean -Pstrict compile test-compile -B -T 1C"
  ],
  "sudo": "required",
  "cache": {
    "directories": [
      "$HOME/.m2"
    ]
  },
  "global_env": "MAVEN_OPTS=-Xmx2048m -Xms1024m",
  "group": "stable",
  "dist": "precise",
  "os": "linux"
}

@asdf2014
Copy link
Member Author

It's weird! In my branch, it works. 😓
https://github.com/asdf2014/druid/commits/travis Build Status

Copy link
Contributor

@drcrallen drcrallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sudo required moves back onto the vm launch method instead of container. Why is that needed?

@asdf2014
Copy link
Member Author

@drcrallen Because changing the .mavenrc file need the sudo permission.

before_install: sudo echo "MAVEN_OPTS='-Xmx2048m -Xms1024m'" > ~/.mavenrc

@drcrallen
Copy link
Contributor

We (administrators) should be able to add environment variables to the build. Is the reason for the expanded heap so that tests can run in parallel?

@asdf2014
Copy link
Member Author

Yeah, the default resource of Travis is few, i think it may be the cause of the task often Timeout.

@drcrallen
Copy link
Contributor

Sudo on echo does not do what you are wanting. This needs thorough testing before acceptance.

@asdf2014
Copy link
Member Author

I think so, maybe my assumption has some problem.

@jihoonson
Copy link
Contributor

Hi @asdf2014, I think we need to figure out what the root cause is and devise an workaround if inevitable.
#4142 is to show the cause of failure when DruidCoordinatorTest fails, and just merged to master. Let's see what happens if this problem occurs again.

@asdf2014
Copy link
Member Author

asdf2014 commented Apr 5, 2017

@jihoonson Wonderful! Look forward to.

@asdf2014
Copy link
Member Author

@drcrallen @jihoonson Travis is good enough. Now close this PR. Thanks for your comments. 👍

@asdf2014 asdf2014 closed this Jul 11, 2018
@asdf2014 asdf2014 deleted the travis branch July 11, 2018 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants