Fix havingSpec on complex aggregators. #5024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Uses the technique from apache#4883 on DimFilterHavingSpec too. - Also uses Transformers from apache#4890, necessitating a move of that and other related classes from druid-server to druid-processing. They probably make more sense there anyway. - Adds a SQL query test. Fixes apache#4957.
gianm
force-pushed
the
sql-fix-having-cd
branch
from
056edd2
to
f783b02
Compare
gianm
added a commit
to implydata/druid-public
that referenced
this pull request
Nov 15, 2017
* Fix havingSpec on complex aggregators. - Uses the technique from apache#4883 on DimFilterHavingSpec too. - Also uses Transformers from apache#4890, necessitating a move of that and other related classes from druid-server to druid-processing. They probably make more sense there anyway. - Adds a SQL query test. Fixes apache#4957. * Remove unused import.
gianm
added a commit
to implydata/druid-public
that referenced
this pull request
Dec 6, 2017
* Fix havingSpec on complex aggregators. - Uses the technique from apache#4883 on DimFilterHavingSpec too. - Also uses Transformers from apache#4890, necessitating a move of that and other related classes from druid-server to druid-processing. They probably make more sense there anyway. - Adds a SQL query test. Fixes apache#4957. * Remove unused import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related classes from druid-server to druid-processing. They probably make
more sense there anyway.
Fixes #4957.