Make parquet extension correctly parse List #5465
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes apache#5433 This change makes Parquet input row reader corrects handle List data type.
|
Failed build is due to a timeout exception in kafka-indexing-service tests, unrelated to my PR. Can somebody retrigger the build? |
jon-wei
reviewed
Mar 5, 2018
| @@ -89,6 +91,9 @@ public boolean containsValue(Object value) | |||
| public Object get(Object key) | |||
| { | |||
| Object field = record.get(key.toString()); | |||
| if (field instanceof ArrayList) { | |||
There was a problem hiding this comment.
Is it possible to get a List that isn't an ArrayList here?
gianm
reviewed
Mar 13, 2018
| @@ -89,6 +91,9 @@ public boolean containsValue(Object value) | |||
| public Object get(Object key) | |||
| { | |||
| Object field = record.get(key.toString()); | |||
| if (field instanceof ArrayList) { | |||
| return Lists.transform((ArrayList) field, item -> String.valueOf(((GenericRecord) item).get(0))); | |||
There was a problem hiding this comment.
Could you include a unit test for this, verifying the behavior works as expected?
|
Hi @gauravkumar37, are you still interested in pursuing this contribution? If so, please let us know if the review comments were helpful. |
|
Hi @gauravkumar37, some similar functionality is added in #6360, so we'll close this PR. But thank you anyway! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5433
This change makes Parquet input row reader corrects handle List data type.
Code is inspired from the avro extension since parquet extension also defers the schema handling logic to avro extension.