Fix cache bug in stats module #5650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jihoonson
approved these changes
Apr 16, 2018
| return new CacheKeyBuilder(AggregatorUtil.VARIANCE_CACHE_TYPE_ID) | ||
| .appendString(fieldName) | ||
| .appendString(inputType) | ||
| .appendBoolean(isVariancePop) |
There was a problem hiding this comment.
nit: isVariancePop is not necessary in getCacheKey(), equals(), and hashCode() because it is decided based on estimator.
sathishsri88
pushed a commit
to sathishs/druid
that referenced
this pull request
May 8, 2018
jihoonson
pushed a commit
to implydata/druid-public
that referenced
this pull request
Jul 6, 2018
jihoonson
pushed a commit
to jihoonson/druid
that referenced
this pull request
Jul 6, 2018
gianm
pushed a commit
that referenced
this pull request
Jul 9, 2018
leventov
pushed a commit
to metamx/druid
that referenced
this pull request
Jul 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2525 introduced the stats module, but it had some bugs in the cache keys, hash codes, and toString methods.
CacheKeyBuilderresetmethod