Wrap query with limit within the web console #7449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vogievetsky
changed the title
|
@vogievetsky this needs to be more obvious, i.e. right beside the run button |
|
@fjy noted: made the button more explicit (see updated screenshot in description) |
gianm
pushed a commit
to implydata/druid-public
that referenced
this pull request
Apr 14, 2019
* wrap with limit * make actual menu checkbox component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few improvements to the perceived querying ability of Druid and also a few style fixes
Also:
Most importantly this PR will auto wrap SQL queries issues via the SQL tab with a ``SELECT * FROM (...) LIMIT 5000
this addresses the issue that the user is likely to type inSELECT * FROM huge_data_source` as their first query and if that is executed verbatim they will not get a good impression of druid. I might have done just that earlier today. This query wrapping can be disabled.This PR also: