Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds backwards-compatible serde for SeekableStreamStartSequenceNumbers. #7512

Merged
merged 1 commit into from
Apr 19, 2019
Merged

Adds backwards-compatible serde for SeekableStreamStartSequenceNumbers. #7512

merged 1 commit into from
Apr 19, 2019

Conversation

gianm
Copy link
Contributor

@gianm gianm commented Apr 19, 2019

This allows them to be deserialized by older Druid versions as
KafkaPartitions objects.

Fixes #7470.

@gianm gianm added this to the 0.15.0 milestone Apr 19, 2019
@gianm
Adds backwards-compatible serde for SeekableStreamStartSequenceNumbers.
65569cd 
This allows them to be deserialized by older Druid versions as
KafkaPartitions objects.

Fixes apache#7470.
@gianm gianm changed the title Adds backwards-compatible verde for SeekableStreamStartSequenceNumbers. Adds backwards-compatible serde for SeekableStreamStartSequenceNumbers. Apr 19, 2019
jihoonson
jihoonson approved these changes Apr 19, 2019
View reviewed changes
Copy link
Contributor

@jihoonson jihoonson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested by running a middleManager of this patch and an overlord of 0.13.0, and killing kafka tasks several times and checking new tasks start properly.

@fjy fjy merged commit 1fb5ec3 into apache:master Apr 19, 2019
@gianm gianm deleted the fix-kis-cp branch April 20, 2019 19:23
@gianm
Copy link
Contributor Author

gianm commented Apr 20, 2019

Thanks for the review & test @jihoonson!

gianm added a commit to implydata/druid-public that referenced this pull request Apr 20, 2019
@gianm
Adds backwards-compatible serde for SeekableStreamStartSequenceNumber…
0e4efb4 
…s. (apache#7512)

This allows them to be deserialized by older Druid versions as
KafkaPartitions objects.

Fixes apache#7470.
clintropolis pushed a commit that referenced this pull request Apr 24, 2019
@gianm @clintropolis
Adds backwards-compatible serde for SeekableStreamStartSequenceNumber…
020a3d2 
…s. (#7512)

This allows them to be deserialized by older Druid versions as
KafkaPartitions objects.

Fixes #7470.
@clintropolis clintropolis modified the milestones: 0.15.0, 0.14.1 Apr 24, 2019
@clintropolis clintropolis mentioned this pull request Apr 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jihoonson jihoonson jihoonson approved these changes

Assignees
No one assigned
Labels
Area - Streaming Ingestion Bug Compatibility
Projects
None yet
Milestone
0.14.1
Development

Successfully merging this pull request may close these issues.

KIS error when upgrading from 0.13 to 0.14
4 participants
@gianm @jihoonson @fjy @clintropolis