Fix old-console/cluster.html; Remove redundant throws in ITBasicAuthConfigurationTest #7589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vogievetsky
reviewed
May 3, 2019
web-console/old-console/cluster.html
Outdated
| @@ -59,7 +59,7 @@ | |||
| <input type="submit" value="Move" /> | |||
| </form> | |||
| </div> | |||
| <!--<div id="drop"> | |||
| <div id="drop"> | |||
There was a problem hiding this comment.
How come you are only removing one side of the comment? I have no idea what this is about but should you also remove the --> on line 67?
There was a problem hiding this comment.
Or is your fix that this comment is unbalanced?
There was a problem hiding this comment.
It looks like it's a comment inside another comment. Might as well just delete the whole thing, I suppose.
There was a problem hiding this comment.
@leventov could you delete the whole comment?
egor-ryashin
requested changes
May 3, 2019
web-console/old-console/cluster.html
Outdated
| @@ -59,7 +59,7 @@ | |||
| <input type="submit" value="Move" /> | |||
| </form> | |||
| </div> | |||
| <!--<div id="drop"> | |||
| <div id="drop"> | |||
There was a problem hiding this comment.
@leventov could you delete the whole comment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue efforts to try to resolve problems that prevent TeamCity from updating to IntelliJ 2018.2 engine, started in #7499 and #7541.