Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix old-console/cluster.html; Remove redundant throws in ITBasicAuthConfigurationTest #7589

Merged
merged 2 commits into from
May 6, 2019
Merged

Fix old-console/cluster.html; Remove redundant throws in ITBasicAuthConfigurationTest #7589

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f3c3a0
Fix old-console/cluster.html; Remove redundant throws in ITBasicAuthC…
leventov May 3, 2019
aad1daa
Remove comment in cluster.html
leventov May 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ion-tests/src/test/java/org/apache/druid/tests/security/ITBasicAuthConfigurationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ public class ITBasicAuthConfigurationTest
private CoordinatorResourceTestClient coordinatorClient;

@BeforeMethod
public void before() throws Exception
public void before()
{
// ensure that auth_test segments are loaded completely, we use them for testing system schema tables
RetryUtil.retryUntilTrue(
Expand Down
2 changes: 1 addition & 1 deletion web-console/old-console/cluster.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
<input type="submit" value="Move" />
</form>
</div>
<!--<div id="drop">
<div id="drop">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come you are only removing one side of the comment? I have no idea what this is about but should you also remove the --> on line 67?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or is your fix that this comment is unbalanced?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it's a comment inside another comment. Might as well just delete the whole thing, I suppose.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leventov could you delete the whole comment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted.

<form id="drop_segment" action="" method="post">
<input type="submit" value="Drop Selected Segments" />
</form>
Expand Down