Teach tasks what machine they are running on #8190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon-wei
reviewed
Jul 29, 2019
| @Retention(RetentionPolicy.RUNTIME) | ||
| @BindingAnnotation | ||
| @PublicApi | ||
| public @interface Parent |
There was a problem hiding this comment.
suggest ParentNode instead to make it more clear what the annotation relates to
There was a problem hiding this comment.
Hmm I want to make it consistent with Self. Do you want me to rename it as well? I guess javadoc is pretty clear now that it relates to DruidNode.
There was a problem hiding this comment.
Hm, that's fine then, no need to rename in this patch
jon-wei
approved these changes
Jul 29, 2019
|
@jihoonson can you fix merge conflicts? |
|
@fjy fixed. |
clintropolis
requested changes
Jul 30, 2019
There was a problem hiding this comment.
overall lgtm, but CliIndexer.java needs to bind parent to self I think since #8107 has been merged.
|
@clintropolis thanks, fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8061.
Description
In parallel native indexing, the middleManager is responsible for serving intermediary data for shuffle. As a result, the phase 2 tasks need to know where phase 1 tasks ran.
This PR lets tasks know where they are running by adding new system properties. This is supposed to be used for only internal purpose and so doesn't have to be documented.
This PR has: