-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check targetCompactionSizeBytes to search for candidate segments in auto compaction #8495
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall lgtm
return candidates | ||
.stream() | ||
.filter(segment -> segment.getSize() < minAllowedSize || segment.getSize() > maxAllowedSize) | ||
.count() > 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I think this should use anyMatch
instead of filter
+ count
since the former might not have to materialize the entire set upon reaching first match
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ignore ^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 after CI
…uto compaction (apache#8495) * Check targetCompactionSizeBytes to search for candidate segments in auto compaction * fix logs * add javadoc * rename
Description
This PR is to resolve the release blocker by temporarily addressing the bug reported in #8481. The auto compaction will check
targetCompactionSizeBytes
with this PR. The real solution should be something better such as #8489.In the release notes, it should be mentioned that the auto compaction can get stuck if
maxRowsPerSegment
ormaxTotalRows
is set instead oftargetCompactionSizeBytes
.This PR has: