Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add javadocs and small improvements to join code. #9196

Merged
merged 1 commit into from
Jan 16, 2020
Merged

Add javadocs and small improvements to join code. #9196

merged 1 commit into from
Jan 16, 2020

Conversation

gianm
Copy link
Contributor

@gianm gianm commented Jan 16, 2020

A follow-up to #9111.

@gianm gianm added the Area - Dev For items related to the project itself, like dev docs and checklists, but not CI label Jan 16, 2020
jihoonson
jihoonson approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@jihoonson jihoonson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 after CI. Thanks.

clintropolis
clintropolis approved these changes Jan 16, 2020
View reviewed changes
Copy link
Member

@clintropolis clintropolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for javadocs 👍

@gianm gianm merged commit bfcb30e into apache:master Jan 16, 2020
@gianm gianm deleted the join-javadocs branch January 16, 2020 23:25
@jihoonson jihoonson added this to the 0.18.0 milestone Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clintropolis clintropolis clintropolis approved these changes

@jihoonson jihoonson jihoonson approved these changes

Assignees
No one assigned
Labels
Area - Dev For items related to the project itself, like dev docs and checklists, but not CI
Projects
None yet
Milestone
0.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gianm @clintropolis @jihoonson