Rollback kinesis lag metric for 0.18.1 #9823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 142742f.
ccaominh
approved these changes
May 5, 2020
clintropolis
approved these changes
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reverts #9509 for 0.18.1. The lag metric for Kinesis was first introduced in 0.18.0, but it turns out there are a couple of flaws in the
RecordSupplierandSeekableStreamSupervisorwhich can freeze the Kinesis supervisor for minutes due to lock contentions. #9819 is to fix such flaws, but I think we should roll back this feature for the minor release since the fix doesn't look simple enough.