Implement dubboctl dashboard subcmd #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into refactor-with-go
…into refactor-with-go
…into refactor-with-go
…into refactor-with-go
…into refactor-with-go
…into refactor-with-go
Codecov Report
@@ Coverage Diff @@
## refactor-with-go #1197 +/- ##
====================================================
- Coverage 49.47% 48.74% -0.73%
====================================================
Files 95 97 +2
Lines 5114 5217 +103
Branches 41 41
====================================================
+ Hits 2530 2543 +13
- Misses 2325 2415 +90
Partials 259 259
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
For simplifying port-forward operation and opening component dashboard in browser directly, implement dashboard subcommand.
eg: dubboctl dashboard grafana
It would create k8s PortForwarder and listen on localhost:3000 automatically. Then it opens grafana dashboard in browser.
Now it supports Admin, Grafana, Nacos, Prometheus, Skywalking, Zipkin.(Zookeeper doesn't have embedded dashboard)
Brief changelog
See /pkg/dubboctl/cmd/subcmd/dashboard_all_cmds. I do not create individual file for every component such as dashboard_grafana cause processing logic for every component is similar. So I aggregate all subcmds about dashboard.
Verifying this change
dubboctl manifest install
dubboctl dashboard grafana