Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #716]Fix nacos dataId can't match dubbo #717

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

haoyann
Copy link
Contributor

@haoyann haoyann commented Mar 27, 2021

The branch of 0.2.0 is master-0.2.0. If your PR is to solve the problem of 0.2.0, please submit the PR to it.
Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

#716

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist.
  • Run `mvn clean compile --batch-mode -DskipTests=false -Dcheckstyle.skip=false -Drat.skip=false -Dmaven.javadoc.skip=true to make sure basic checks pass.

Copy link
Contributor

@KeRan213539 KeRan213539 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@KeRan213539 KeRan213539 merged commit 6ec3d8e into apache:develop Mar 29, 2021
KeRan213539 added a commit that referenced this pull request Mar 30, 2021
* Fix and optimize some problems of conditional routing when using ZK to make it work (#704)

* Fix and optimize some problems of conditional routing when using ZK to make it work

* Fix UT problem

* fix #19 of api docs bug , apache/dubbo-spi-extensions#19 (#707)

* nacos support auth (#709)

Co-authored-by: yanhao <yanhao@tinman.cn>

* Fix route rule some problem (#712)

* `BaseDTO` remove service
fix condition query problem

* remove condition service group
fix serviceGroup and serviceVersion null string

* fix test

* fix condition application query

* fix ci

* fix #714 (#719)

Co-authored-by: tangziran <823013778@qqcom>

* fix nacos dataId can't match dubbo (#717)

* Merge the latest code into the antd branch

Co-authored-by: haoyann <1064645534@qq.com>
Co-authored-by: yanhao <yanhao@tinman.cn>
Co-authored-by: tzr164 <tzr164@163.com>
Co-authored-by: tangziran <823013778@qqcom>
@haoyann haoyann deleted the fix-nacos-dataId branch July 26, 2021 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants