Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoyann
reviewed
Oct 9, 2021
| @@ -60,35 +49,27 @@ public String login(HttpServletRequest httpServletRequest, @RequestParam String | |||
| boolean flag = true; | |||
| if (iterator == null) { | |||
There was a problem hiding this comment.
Use (iterator != null && !iterator.hasNext()) better.
| break; | ||
| } | ||
| } | ||
| if (flag) { | ||
| return creatToken(userName); | ||
| return JwtTokenUtil.generateToken(userName); | ||
| } | ||
| return null; |
There was a problem hiding this comment.
Should use AuthInterceptor.loginFailResponse not return null.
| @Scheduled(cron= "0 5 * * * ?") | ||
| public void clearExpiredToken() { | ||
| tokenMap.entrySet().removeIf(entry -> entry.getValue() == null || System.currentTimeMillis() - entry.getValue().getLastUpdateTime() > sessionTimeoutMilli); | ||
| return true; | ||
| } | ||
|
|
||
| public static class User { |
There was a problem hiding this comment.
If User class not use should be removed.
| /** | ||
| * Jwt signingKey | ||
| */ | ||
| private static final String secret = "a1g2y47dg3dj59fjhhsd7cnewy73j"; |
There was a problem hiding this comment.
secret and expiration should be configurable.
Codecov Report
@@ Coverage Diff @@
## develop #832 +/- ##
=============================================
+ Coverage 20.75% 20.89% +0.14%
- Complexity 424 429 +5
=============================================
Files 145 147 +2
Lines 4790 4795 +5
Branches 731 731
=============================================
+ Hits 994 1002 +8
+ Misses 3720 3714 -6
- Partials 76 79 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
KeRan213539
approved these changes
Oct 13, 2021
KeRan213539
added a commit
that referenced
this pull request
Nov 18, 2021
* set branch protection * rat exclude ".asf.yaml" * add master-0.2.0 to branch protection * Exclude the".flattened-pom.xml" file into the source package (#799) * Update copyright year (#801) * fix NPE in ServiceTestUtil.java (#804) * polish dockerfile for 0.3.0 (#805) * update dockerfile and enable autotest * fix test script * fix zookeeper version * fix rat * develop-for-dubbo-3.x branch merge to develop branch (#808) * [3.0]Add mesh rule route (#789) * add mesh rule route * add mesh rule check * For #756 (#791) * [ISSUE #760]Application discover support (#807) * application discover support * fix checkstyle * fix ci * remove useless pom import,modify Chinese comment * fix UT bug Co-authored-by: haoyann <1064645534@qq.com> Co-authored-by: Aaron-boom <55744718+Aaron-boom@users.noreply.github.com> * Fix generic invoke fail (#810) * fix generic invoke fail * fix ci * Nacos support application discover (#812) * Fix generic can't invoke repeatedly (#814) * Reduce nacos mapping service storage (#817) * optimize some code for RegistryServerSync (#822) * Fix circular reference (#823) * Fix service version spell (#824) * For #756 (#815) * For #756 * for 830 (#832) * for 830 * For 830 * For 830 * For 830 * For 830 * For 830 * [Feature] Dubbo Admin provides service mock ability. (#838) * commit the API * develop the front page. * add edit logic * develop the front page and test. * ui change * change the config key and group * change rule enable to config center. * update GlobalMockRule update logic. * remove the GlobalMockRule * [feature admin mock] move the diver dependency out of the project. * [feature admin mock] remove the contributor name and date in javadoc. * [feature admin mock] optimize the delete mock rule step. * [feature admin mock] fix the dialog cannot be closed when delete successfully. * [feature admin mock] add the support for h2 database. * [feature admin mock] rollback to zookeeper registry. * [feature admin mock] fix properties. * [feature admin mock] change mock-admin-api maven version. * [feature admin mock] fix the feedback and add the parameters in docker-compose. * [feature admin mock] fix the ci problem. * [feature admin mock] fix the ci problem. * [feature admin mock] removed unused import. * [feature admin mock] add license. * GovernanceConfiguration use dubbo instead DynamicConfiguration (#840) * GovernanceConfiguration use dubbo instead DynamicConfiguration * remove useless change Co-authored-by: wuwen <wuwen.55@aliyun.com> Co-authored-by: Huang YunKun <htynkn@gmail.com> Co-authored-by: haoyann <1064645534@qq.com> Co-authored-by: Aaron-boom <55744718+Aaron-boom@users.noreply.github.com> Co-authored-by: Wang Chengming <634749869@qq.com> Co-authored-by: brotherlu-xcq <1285823170@qq.com>
KeRan213539
added a commit
that referenced
this pull request
Oct 9, 2022
* set branch protection * rat exclude ".asf.yaml" * add master-0.2.0 to branch protection * Exclude the".flattened-pom.xml" file into the source package (#799) * Update copyright year (#801) * fix NPE in ServiceTestUtil.java (#804) * polish dockerfile for 0.3.0 (#805) * update dockerfile and enable autotest * fix test script * fix zookeeper version * fix rat * develop-for-dubbo-3.x branch merge to develop branch (#808) * [3.0]Add mesh rule route (#789) * add mesh rule route * add mesh rule check * For #756 (#791) * [ISSUE #760]Application discover support (#807) * application discover support * fix checkstyle * fix ci * remove useless pom import,modify Chinese comment * fix UT bug Co-authored-by: haoyann <1064645534@qq.com> Co-authored-by: Aaron-boom <55744718+Aaron-boom@users.noreply.github.com> * Fix generic invoke fail (#810) * fix generic invoke fail * fix ci * Nacos support application discover (#812) * Fix generic can't invoke repeatedly (#814) * Reduce nacos mapping service storage (#817) * optimize some code for RegistryServerSync (#822) * Fix circular reference (#823) * Fix service version spell (#824) * For #756 (#815) * For #756 * for 830 (#832) * for 830 * For 830 * For 830 * For 830 * For 830 * For 830 * [Feature] Dubbo Admin provides service mock ability. (#838) * commit the API * develop the front page. * add edit logic * develop the front page and test. * ui change * change the config key and group * change rule enable to config center. * update GlobalMockRule update logic. * remove the GlobalMockRule * [feature admin mock] move the diver dependency out of the project. * [feature admin mock] remove the contributor name and date in javadoc. * [feature admin mock] optimize the delete mock rule step. * [feature admin mock] fix the dialog cannot be closed when delete successfully. * [feature admin mock] add the support for h2 database. * [feature admin mock] rollback to zookeeper registry. * [feature admin mock] fix properties. * [feature admin mock] change mock-admin-api maven version. * [feature admin mock] fix the feedback and add the parameters in docker-compose. * [feature admin mock] fix the ci problem. * [feature admin mock] fix the ci problem. * [feature admin mock] removed unused import. * [feature admin mock] add license. * GovernanceConfiguration use dubbo instead DynamicConfiguration (#840) * GovernanceConfiguration use dubbo instead DynamicConfiguration * remove useless change * for release 0.4.0 (#850) * [ISSUE #856] update README.md (#857) * 修复更新，删除service类型的条件路由异常的问题 (#861) * Fix flaky (#883) * fix flaky test * Delete dubbo-admin-server/.nondex directory Co-authored-by: Ubuntu <rootadmin@vm001.qmx3d0w2ozeuflvliyjbpujvhf.bx.internal.cloudapp.net> * support jdk11 #862 (#886) * support jdk11 #862 * support jdk11 #862 Co-authored-by: 卫龙 <weilong@yeteam.com> * fix #895 (#896) Co-authored-by: 卫龙 <weilong@yeteam.com> * fix #893 (#894) fix #893 Co-authored-by: 卫龙 <weilong@yeteam.com> * Update index.html (#899) 原cdn.bootcss.com域名失效，需要切换到新域名cdn.bootcdn.net 官网申明：https://www.bootcdn.cn * support swagger.enable (#902) * support swagger.enable * enable swagger by default Co-authored-by: 璟源 <jingyuan.mj@alibaba-inc.com> * support dubbo 3.0.8 (#903) * [Fix bug](#908) (#910) * ZookeeperMetaDataCollector init method add zk digest acl support (#911) * Fix notice and opt registry source (#913) * update year * fix search * add relation support * disable swagger * Bump fastjson from 1.2.67 to 1.2.83 (#907) Bumps [fastjson](https://github.com/alibaba/fastjson) from 1.2.67 to 1.2.83. - [Release notes](https://github.com/alibaba/fastjson/releases) - [Commits](alibaba/fastjson@1.2.67...1.2.83) --- updated-dependencies: - dependency-name: com.alibaba:fastjson dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add seriialization & timeout (#914) * update year * fix search * add relation support * disable swagger * fix interface * fix interface * 解决重复点功能，浏览器控制台报错问题，如点击：服务查询-搜索按钮 (#916) * Fix error when host is null (#920) * 解决重复点功能，浏览器控制台报错问题，如点击：服务查询-搜索按钮 * 解决可能产生的空指针问题，导致 '消费者'标签无法显示数据 * 解决在服务测试，方法执行成功后。动态生成的consumer元数据，host取值为空的问题情况（dubbo version 3.0.8） * Update ServiceDetail.vue (#921) * Up develop (#926) * release 0.5.0 Co-authored-by: wuwen <wuwen.55@aliyun.com> Co-authored-by: Huang YunKun <htynkn@gmail.com> Co-authored-by: haoyann <1064645534@qq.com> Co-authored-by: Aaron-boom <55744718+Aaron-boom@users.noreply.github.com> Co-authored-by: Wang Chengming <634749869@qq.com> Co-authored-by: brotherlu-xcq <1285823170@qq.com> Co-authored-by: Robert LU <robberphex@gmail.com> Co-authored-by: ymybxx <775289630@qq.com> Co-authored-by: plzdoo <55066376+plzdoo@users.noreply.github.com> Co-authored-by: Ubuntu <rootadmin@vm001.qmx3d0w2ozeuflvliyjbpujvhf.bx.internal.cloudapp.net> Co-authored-by: chenjjl <50745778+chenjjl@users.noreply.github.com> Co-authored-by: 卫龙 <weilong@yeteam.com> Co-authored-by: VirensCn <595170292@qq.com> Co-authored-by: itmajing <itmajing@163.com> Co-authored-by: 璟源 <jingyuan.mj@alibaba-inc.com> Co-authored-by: sherl0ckLiu <108274057+sherl0ckLiu@users.noreply.github.com> Co-authored-by: sage.xue <job.xueqi@outlook.com> Co-authored-by: Albumen Kevin <jhq0812@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: cnjxzhao <85160585+cnjxzhao@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#830