Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #253: Acquire sufficient bytes for string encoding buffers #255

Merged
merged 1 commit into from
Jan 12, 2021
Merged

Fix #253: Acquire sufficient bytes for string encoding buffers #255

merged 1 commit into from
Jan 12, 2021

Conversation

lujjjh
Copy link
Contributor

@lujjjh lujjjh commented Jan 9, 2021

What this PR does:

Acquire sufficient bytes for string encoding buffers.

Which issue(s) this PR fixes:

Fixes #253

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

- fix index out of range in some string encoding cases

@codecov-io
Copy link

codecov-io commented Jan 9, 2021

Codecov Report

Merging #255 (0b4c6a8) into master (ab7254f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #255   +/-   ##
=======================================
  Coverage   67.61%   67.61%           
=======================================
  Files          25       25           
  Lines        2671     2671           
=======================================
  Hits         1806     1806           
  Misses        644      644           
  Partials      221      221           
Impacted Files Coverage Δ
string.go 70.70% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab7254f...0b4c6a8. Read the comment docs.

@AlexStocks AlexStocks merged commit c052455 into apache:master Jan 12, 2021
zhaoyunxing92 pushed a commit that referenced this pull request Sep 4, 2021
Fix #253: Acquire sufficient bytes for string encoding buffers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

String encoding and decoding
6 participants