[Ftr] tracing #236
Merged
[Ftr] tracing #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ztelur
reviewed
Aug 6, 2021
tydhot
reviewed
Aug 7, 2021
AlexStocks
reviewed
Aug 7, 2021
AlexStocks
reviewed
Aug 7, 2021
AlexStocks
reviewed
Aug 31, 2021
pkg/filter/tracing/tracing.go
Outdated
| "net/http" | ||
| "time" | ||
|
|
||
| "go.opentelemetry.io/otel/trace" |
tydhot
reviewed
Aug 31, 2021
Codecov Report
@@ Coverage Diff @@
## develop #236 +/- ##
===========================================
- Coverage 40.18% 39.65% -0.54%
===========================================
Files 50 50
Lines 2541 2575 +34
===========================================
Hits 1021 1021
- Misses 1410 1444 +34
Partials 110 110
Continue to review full report at Codecov.
|
tydhot
reviewed
Sep 10, 2021
|
|
||
| // Do execute tracerFilter filter logic. | ||
| func (f TraceFilter) Handle(hc *contexthttp.HttpContext) { | ||
| spanName := spanNamePrefix + hc.Request.Method + " " + hc.Request.URL.Path |
There was a problem hiding this comment.
一般情况下在网关层spanName直接到method就可以了，不需要把url path作为spanName。这是一个会无限膨胀的字段，会给后期聚合带来非常大的困难。
tydhot
reviewed
Sep 10, 2021
| @@ -60,3 +64,31 @@ func HttpRouteActionMatch(c *HttpContext, ra model.RouteAction) bool { | |||
|
|
|||
| return true | |||
| } | |||
|
|
|||
| // ExtractRequestBody extract body of http request | |||
| func ExtractRequestBody(req *http.Request) []byte { | |||
There was a problem hiding this comment.
我还是建议不要采集body了，如果这是个上传文件的请求，或是敏感请求，不是很合适
ztelur
approved these changes
Sep 18, 2021
AlexStocks
approved these changes
Sep 18, 2021
xiaoliu10
approved these changes
Sep 18, 2021
mark4z
pushed a commit
that referenced
this pull request
Nov 7, 2021
[Ftr] tracing Former-commit-id: 59c6681
bobtthp
pushed a commit
to bobtthp/dubbo-go-pixiu
that referenced
this pull request
Dec 12, 2022
[Ftr] tracing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:Support jaeger tracing
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: