Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use wasmer-go v1.0.4 which is compatible with mac arm #515

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

ma642
Copy link
Contributor

@ma642 ma642 commented Oct 30, 2022

What this PR does: use wasmer-go v1.0.4 which is compatible with mac arm

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?: NONE


@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2022

Codecov Report

Merging #515 (69b219d) into develop (b71ac6e) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #515      +/-   ##
===========================================
+ Coverage    54.73%   54.74%   +0.01%     
===========================================
  Files          666      664       -2     
  Lines        77905    77746     -159     
===========================================
- Hits         42638    42559      -79     
+ Misses       31635    31550      -85     
- Partials      3632     3637       +5     
Impacted Files Coverage Δ
security/pkg/credentialfetcher/fetcher.go 40.00% <0.00%> (-20.00%) ⬇️
pkg/envoy/admin.go 50.00% <0.00%> (-9.68%) ⬇️
pkg/istio-agent/xds_proxy_delta.go 46.11% <0.00%> (-6.22%) ⬇️
...try/kube/controller/autoserviceexportcontroller.go 61.11% <0.00%> (-4.17%) ⬇️
pkg/config/mesh/watcher.go 65.95% <0.00%> (-3.20%) ⬇️
pkg/envoy/instance.go 76.27% <0.00%> (-1.70%) ⬇️
pilot/pkg/bootstrap/certcontroller.go 42.51% <0.00%> (-1.20%) ⬇️
pkg/config/mesh/mesh.go 77.95% <0.00%> (-1.08%) ⬇️
pilot/pkg/xds/discovery.go 84.93% <0.00%> (-0.97%) ⬇️
pilot/pkg/model/service.go 46.60% <0.00%> (-0.91%) ⬇️
... and 15 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@mark4z mark4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexStocks AlexStocks merged commit 9a1e84b into apache:develop Oct 31, 2022
bobtthp pushed a commit to bobtthp/dubbo-go-pixiu that referenced this pull request Dec 12, 2022
* use wasmer-go v1.0.4 which is compatible with mac arm

* fix build issue

Co-authored-by: mazhihui <mazhihui@baimaohui.net>
@mark4z mark4z added this to the v1.0.0 milestone Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants