replace default config string with const value #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexStocks
approved these changes
Apr 28, 2021
Mulavar
force-pushed
the
refactor-default-config
branch
from
260fde4
to
d912b22
Compare
zouyx
reviewed
Apr 29, 2021
zouyx
approved these changes
Apr 29, 2021
wongoo
approved these changes
Apr 29, 2021
zhaoyunxing92
approved these changes
Apr 29, 2021
AlexStocks
pushed a commit
that referenced
this pull request
May 7, 2021
* add retry times * Add: add ruubypay to user list. (#1180) * fix import for linter * replace default config string with const value (#1182) * replace default config string with const value * delete some duplicate keys Co-authored-by: dongjianhui <dongjianhui@yuanfudao.com> * Fix 3.0 ci problem (#1188) * fix etcd problem * fix metadata report etcd problem * fix nacos & cluster_impl ci problem * fix nacos ci problem * fix zk ci problem * fix zk metadata service urls not found error * fix zk TestAddListenerZookeeperServiceDiscovery * fix zk TestAddListenerZookeeperServiceDiscovery * fix config int to string bug * add retry times * fix import for linter * revert rename etcdv3 Co-authored-by: xianlezheng <zhengxianle@gmail.com> Co-authored-by: Mulavar <978007503@qq.com> Co-authored-by: dongjianhui <dongjianhui@yuanfudao.com> Co-authored-by: randy <ztelur@gmail.com> Co-authored-by: 蒋超 <jiangchao@jiangchaodeMacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
replace default config string with const value
Which issue(s) this PR fixes:
Fixes #
none
Special notes for your reviewer:
Does this PR introduce a user-facing change?: