Fix 3.0 ci problem #1188
Merged
Fix 3.0 ci problem #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.0 #1188 +/- ##
==========================================
- Coverage 59.53% 56.61% -2.92%
==========================================
Files 259 254 -5
Lines 12737 12485 -252
==========================================
- Hits 7583 7069 -514
- Misses 4199 4536 +337
+ Partials 955 880 -75
Continue to review full report at Codecov.
|
zouyx
reviewed
May 5, 2021
| @@ -51,6 +50,7 @@ require ( | |||
| github.com/stretchr/objx v0.2.0 // indirect | |||
| github.com/stretchr/testify v1.7.0 | |||
| github.com/zouyx/agollo/v3 v3.4.5 | |||
| go.etcd.io/etcd v0.0.0-20200402134248-51bdeb39e698 | |||
There was a problem hiding this comment.
suggest use version+incompatible, like v3.3.25+incompatible
| @@ -169,7 +169,7 @@ func (invoker *failbackClusterInvoker) Invoke(ctx context.Context, invocation pr | |||
| logger.Errorf("Failback to invoke the method %v in the service %v, wait for retry in background. Ignored exception: %v.\n", | |||
| methodName, url.Service(), result.Error().Error()) | |||
| // ignore | |||
| return &protocol.RPCResult{Err: result.Error()} | |||
| return &protocol.RPCResult{} | |||
AlexStocks
approved these changes
May 6, 2021
LaurenceLiZhixin
approved these changes
May 6, 2021
wenxuwan
approved these changes
May 6, 2021
AlexStocks
pushed a commit
that referenced
this pull request
May 7, 2021
* add retry times * Add: add ruubypay to user list. (#1180) * fix import for linter * replace default config string with const value (#1182) * replace default config string with const value * delete some duplicate keys Co-authored-by: dongjianhui <dongjianhui@yuanfudao.com> * Fix 3.0 ci problem (#1188) * fix etcd problem * fix metadata report etcd problem * fix nacos & cluster_impl ci problem * fix nacos ci problem * fix zk ci problem * fix zk metadata service urls not found error * fix zk TestAddListenerZookeeperServiceDiscovery * fix zk TestAddListenerZookeeperServiceDiscovery * fix config int to string bug * add retry times * fix import for linter * revert rename etcdv3 Co-authored-by: xianlezheng <zhengxianle@gmail.com> Co-authored-by: Mulavar <978007503@qq.com> Co-authored-by: dongjianhui <dongjianhui@yuanfudao.com> Co-authored-by: randy <ztelur@gmail.com> Co-authored-by: 蒋超 <jiangchao@jiangchaodeMacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: