-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Make the Consumer config property Check
available
#1568
Conversation
This reverts commit a109967.
…ache#1387) Bumps [github.com/dubbogo/gost](https://github.com/dubbogo/gost) from 1.11.14 to 1.11.16. - [Release notes](https://github.com/dubbogo/gost/releases) - [Commits](dubbogo/gost@v1.11.14...v1.11.16) --- updated-dependencies: - dependency-name: github.com/dubbogo/gost dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…pache#1386) Bumps [google.golang.org/protobuf](https://github.com/protocolbuffers/protobuf-go) from 1.26.0 to 1.27.1. - [Release notes](https://github.com/protocolbuffers/protobuf-go/releases) - [Changelog](https://github.com/protocolbuffers/protobuf-go/blob/master/release.bash) - [Commits](protocolbuffers/protobuf-go@v1.26.0...v1.27.1) --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
….0 (apache#1383) Bumps [go.etcd.io/etcd/client/v3](https://github.com/etcd-io/etcd) from 3.5.0-alpha.0 to 3.5.0. - [Release notes](https://github.com/etcd-io/etcd/releases) - [Changelog](https://github.com/etcd-io/etcd/blob/main/CHANGELOG-3.5.md) - [Commits](etcd-io/etcd@v3.5.0-alpha.0...v3.5.0) --- updated-dependencies: - dependency-name: go.etcd.io/etcd/client/v3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…se the Consumer config when omitted
@@ -46,7 +46,7 @@ type ReferenceConfig struct { | |||
pxy *proxy.Proxy | |||
id string | |||
InterfaceName string `required:"true" yaml:"interface" json:"interface,omitempty" property:"interface"` | |||
Check *bool `default:"true" yaml:"check" json:"check,omitempty" property:"check"` | |||
Check *bool `yaml:"check" json:"check,omitempty" property:"check"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为什么要删除default设置
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为了让 Reference Config 的 check 延用 Consumer Config 的 check 配置,
如果 reference 的 check 有默认值,就没法判断是用户自己配置的还是默认的
I would merge master to your repo, and ci may pass. |
Codecov Report
@@ Coverage Diff @@
## 3.0 #1568 +/- ##
=======================================
Coverage 41.83% 41.84%
=======================================
Files 258 258
Lines 15115 15117 +2
=======================================
+ Hits 6324 6325 +1
- Misses 8049 8050 +1
Partials 742 742
Continue to review full report at Codecov.
|
What this PR does:
Make the Consumer config property
Check
availableWhich issue(s) this PR fixes:
Fixes #1555
Special notes for your reviewer:
check
use the Consumer config when omitted.check
Does this PR introduce a user-facing change?:
NONE