Add comments for config_center #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #545 +/- ##
===========================================
- Coverage 67.20% 66.92% -0.29%
===========================================
Files 174 174
Lines 9261 9261
===========================================
- Hits 6224 6198 -26
- Misses 2432 2455 +23
- Partials 605 608 +3
Continue to review full report at Codecov.
|
|
change base to develop pls |
zouyx
reviewed
May 29, 2020
config_center/apollo/listener.go
Outdated
| @@ -49,15 +49,15 @@ func (a *apolloListener) OnChange(changeEvent *agollo.ChangeEvent) { | |||
| } | |||
| } | |||
|
|
|||
| // AddListener ... | |||
| // AddListener add a listener for apollo | |||
There was a problem hiding this comment.
Suggested change
| // AddListener add a listener for apollo | |
| // AddListener adds a listener for apollo |
config_center/apollo/listener.go
Outdated
| @@ -29,7 +29,7 @@ type apolloListener struct { | |||
| listeners map[config_center.ConfigurationListener]struct{} | |||
| } | |||
|
|
|||
| // NewApolloListener ... | |||
| // NewApolloListener new an apolloListener | |||
There was a problem hiding this comment.
Suggested change
| // NewApolloListener new an apolloListener | |
| // NewApolloListener creates a new apolloListener |
config_center/apollo/listener.go
Outdated
| func (a *apolloListener) AddListener(l config_center.ConfigurationListener) { | ||
| if _, ok := a.listeners[l]; !ok { | ||
| a.listeners[l] = struct{}{} | ||
| agollo.AddChangeListener(a) | ||
| } | ||
| } | ||
|
|
||
| // RemoveListener ... | ||
| // RemoveListener remove listeners of apollo |
There was a problem hiding this comment.
Suggested change
| // RemoveListener remove listeners of apollo | |
| // RemoveListener removes listeners of apollo |
flycash
reviewed
May 29, 2020
hxmhlt
approved these changes
May 30, 2020
flycash
approved these changes
May 30, 2020
zouyx
approved these changes
May 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add comments for config_center
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: