Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:issue #68 #82

Merged
merged 1 commit into from
Jun 7, 2019
Merged

Fix:issue #68 #82

merged 1 commit into from
Jun 7, 2019

Conversation

fangyincheng
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #68

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@codecov-io
Copy link

codecov-io commented Jun 6, 2019

Codecov Report

Merging #82 into master will increase coverage by 0.52%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage    67.8%   68.33%   +0.52%     
==========================================
  Files          49       49              
  Lines        3414     3414              
==========================================
+ Hits         2315     2333      +18     
+ Misses        868      848      -20     
- Partials      231      233       +2
Impacted Files Coverage Δ
registry/zookeeper/zk_client.go 54.96% <ø> (ø) ⬆️
registry/zookeeper/registry.go 64.06% <ø> (ø) ⬆️
protocol/dubbo/listener.go 59.06% <100%> (ø) ⬆️
protocol/dubbo/codec.go 77.77% <100%> (ø) ⬆️
protocol/dubbo/pool.go 69.72% <0%> (+9.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bde923...9f1a565. Read the comment docs.

@AlexStocks
Copy link
Contributor

LGTM

@ralf0131 ralf0131 merged commit e6882ec into apache:master Jun 7, 2019
@fangyincheng fangyincheng deleted the fix-exception branch March 21, 2020 05:36
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: java-client can not get error message when go-server return error
4 participants