Fix: event driven chain cache #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
December 9, 2020 09:49
AlexStocks
reviewed
Jan 17, 2021
| } | ||
|
|
||
| selectedInvoker := lb.Select(invokers, invocation) | ||
|
|
||
| //judge to if the selectedInvoker is invoked | ||
|
|
||
| //judge to if the selectedInvoker is invoked and available |
There was a problem hiding this comment.
can not get the meaning of this chinglish sentence
AlexStocks
reviewed
Jan 17, 2021
protocol/rpc_status.go
Outdated
| } | ||
|
|
||
| // TryRefreshBlackList start 3 gr to check at most block=16 invokers in black list | ||
| // if is available remove from black list |
There was a problem hiding this comment.
can not know what is the meaning of this sentence.
AlexStocks
force-pushed
the
develop
branch
3 times, most recently
from
25c3b98
to
9a666eb
Compare
AlexStocks
reviewed
Jan 23, 2021
|
|
||
| package conncheck | ||
|
|
||
| import ( |
…ceLiZhixin/dubbo-go into fix/eventDrivenChainCache
AlexStocks
approved these changes
Jan 25, 2021
watermelo
reviewed
Jan 28, 2021
| @@ -148,7 +148,13 @@ conditions: | |||
| url := getConditionRouteUrl(applicationKey) | |||
| assert.NotNil(t, url) | |||
| factory := extension.GetRouterFactory(url.Protocol) | |||
| r, err := factory.NewPriorityRouter(url) | |||
| notify := make(chan struct{}) | |||
| go func() { | |||
Closed
cityiron
approved these changes
Feb 4, 2021
| @@ -121,38 +121,45 @@ func (invoker *baseClusterInvoker) doSelect(lb cluster.LoadBalance, invocation p | |||
|
|
|||
| func (invoker *baseClusterInvoker) doSelectInvoker(lb cluster.LoadBalance, invocation protocol.Invocation, invokers []protocol.Invoker, invoked []protocol.Invoker) protocol.Invoker { | |||
| if len(invokers) == 0 { | |||
There was a problem hiding this comment.
这个地方比较有意思，是改了个已有的坑。
invocation.Invoker()是个nil，所以一走到这一行就会panic。
后来发现这里不会被执行到。不存在invokers列表为空的情况。所以决定删掉这行日志了。
watermelo
reviewed
Feb 5, 2021
protocol/rpc_status.go
Outdated
| go func(ivks []Invoker, i int) { | ||
| defer wg.Done() | ||
| for j, _ := range ivks { | ||
| if j%3-i == 0 { |
| return invokers[0] | ||
| } | ||
| protocol.SetInvokerUnhealthyStatus(invokers[0]) | ||
| logger.Errorf("the invokers of %s is nil. ", invokers[0].GetUrl().ServiceKey()) |
There was a problem hiding this comment.
这个错误日志看起来跟上下文无关，或者是否应该放在 SetInvokerUnhealthyStatus 里更合适
There was a problem hiding this comment.
这里位置主要是针对invokers列表因为健康检查导致为空时，打印出对应失败的key。
|
|
||
| for _, invoker := range invokers { | ||
| if !invoker.IsAvailable() { | ||
| for i := 0; i < 3; i++ { |
There was a problem hiding this comment.
当整个循环次数超过 3 次，最后还是会返回最开始不可用的 selectedInvoker ，是否符合预期
There was a problem hiding this comment.
Yes, you r right, I've fixed it.
watermelo
approved these changes
Feb 6, 2021
AlexStocks
pushed a commit
that referenced
this pull request
Apr 14, 2021
Fix: event driven chain cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR is based on pr #915
pr 915 aims at fix health check——add black list logic, and split conn check router from health check router.
This PR aims at using event-driven to let router send signal to notify channel, to notify chain to refresh its cache.
Not ticker dirven like before, but event driven.
This can descrease the CPU usage, as there is no longer useless comparasion of invoker list of chain, but only compare when invokers/router change.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: