Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it subscribing all possible targets when set version to '*' or empty #129

Merged
merged 1 commit into from
Aug 8, 2019

Conversation

jasonjoo2010
Copy link
Contributor

Version should be an optional value and compatible with Dubbo's wildcard gramma '*'.

Reference to #126

Copy link
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a node.js expert, but this look good to me.

@jasonjoo2010
Copy link
Contributor Author

I am not a node.js expert, but this look good to me.

And we have already published it into a alias repository: https://www.npmjs.com/package/@yoloho/dubbo-js

Yet everything seems good and we can get rid of version=0.0.0 finally.

@ralf0131
Copy link
Contributor

ralf0131 commented Aug 8, 2019

And we have already published it into a alias repository: https://www.npmjs.com/package/@yoloho/dubbo-js

Please do not do this. dubbo-js is an Apache Dubbo project, has it own branding policy. You may in the way of infringing Dubbo's brand.
Please wait for the official project to publish the arthifact.

Yet everything seems good and we can get rid of version=0.0.0 finally.

Let me merge it.

Copy link
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ralf0131 ralf0131 merged commit 2457af4 into apache:master Aug 8, 2019
@jasonjoo2010
Copy link
Contributor Author

jasonjoo2010 commented Aug 8, 2019

Please wait for the official project to publish the arthifact.

Because we have two project affected wait to deploy. But now I indeed have trouble to remove the package from npmjs.org..............

I have noticed what you said and will pay attention in future.

Thanks

@jasonjoo2010
Copy link
Contributor Author

And more may I ask the schedule of dubbo-js@3.0.0 (which the old package name is dubbo2.js)?

@ralf0131
Copy link
Contributor

ralf0131 commented Aug 8, 2019

Please wait for the official project to publish the arthifact.

Because we have two project affected wait to deploy. But now I indeed have trouble to remove the package from npmjs.org..............

I have noticed what you said and will pay attention in future.

Thanks

It's okay as long as you deprecate it.

@ralf0131
Copy link
Contributor

ralf0131 commented Aug 8, 2019

And more may I ask the schedule of dubbo-js@3.0.0 (which the old package name is dubbo2.js)?

Yes, there is a plan to release, maybe @hufeng could explain the details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants