-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it subscribing all possible targets when set version to '*' or empty #129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not a node.js expert, but this look good to me.
And we have already published it into a alias repository: https://www.npmjs.com/package/@yoloho/dubbo-js Yet everything seems good and we can get rid of |
Please do not do this. dubbo-js is an Apache Dubbo project, has it own branding policy. You may in the way of infringing Dubbo's brand.
Let me merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Because we have two project affected wait to deploy. But now I indeed have trouble to remove the package from I have noticed what you said and will pay attention in future. Thanks |
And more may I ask the schedule of |
It's okay as long as you deprecate it. |
Yes, there is a plan to release, maybe @hufeng could explain the details. |
Version should be an optional value and compatible with Dubbo's wildcard gramma '*'.
Reference to #126