Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it subscribing all possible targets when set version to '*' or empty #129

Merged
merged 1 commit into from
Aug 8, 2019
Merged

Make it subscribing all possible targets when set version to '*' or empty #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/dubbo/src/registry/registry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,10 @@ export default class Registry<T = {}> {
return this._dubboServiceUrlMap
.get(dubboInterface)
.filter(serviceProp => {
const isSameVersion = serviceProp.version === version;
// "*" refer to default wildcard in dubbo
const isSameVersion = !version
|| version == '*'
|| serviceProp.version === version;
//如果Group为null，就默认匹配， 不检查group
//如果Group不为null，确保group和接口的group一致
const isSameGroup = !group || group === serviceProp.group;
Expand Down