Skip to content

Commit

Permalink
fix: prevent the test being ignored
Browse files Browse the repository at this point in the history
  • Loading branch information
plusmancn committed Sep 17, 2021
1 parent a92b10f commit 6c814d2
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 5 deletions.
12 changes: 8 additions & 4 deletions dubbo-samples-migration/README.md
Expand Up @@ -15,20 +15,24 @@ dubbo.consumer.version=2.7.*
```
And then in each consumer and provider project, you can configure `POM`'s properties as follows:
```xml
# consumer side
<!-- consumer side -->
<properties>
<dubbo.consumer.version>2.7.13</dubbo.consumer.version>
</properties>

# provider side
<!-- provider side -->
<properties>
<dubbo.provider.version>2.7.13</dubbo.provider.version>
</properties>
```

When the Integration Tests trigger, these properties will be overwritten by maven, for example:
If we have the env of `DUBBO_VERSION=3.0.3-SNAPSHOT,2.7.13`, when the Integration Tests trigger, these properties will be overwritten by maven, for example:
```shell
mvn -Ddubbo.provider.version=3.0.3-SNAPSHOT -Ddubbo.consumer.version=2.7.13 -Dspring.version=4.3.16.RELEASE
```


But in the dubbo-samples's Dubbo 3 CI env, there only has `DUBBO_VERSION=3.0.3-SNAPSHOT`, we have to specify one side's version to prevent the test being ignored, for example:
```yaml
dubbo.provider.version=3.*
dubbo.consumer.version=2.7.13 # <= specific version
```
Expand Up @@ -23,4 +23,4 @@ spring.version=4.*, 5.*

# Support Compatibility test
dubbo.provider.version=3.*
dubbo.consumer.version=2.7.*
dubbo.consumer.version=2.7.13

0 comments on commit 6c814d2

Please sign in to comment.