Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade autowire samples #1063

Closed
wants to merge 3 commits into from

Conversation

kkkjsh
Copy link
Contributor

@kkkjsh kkkjsh commented Mar 14, 2024

Modify 2-advanced/dubbo-sample-autowire org.slf4j.Logger to org.apache.dubbo.common.logger.
upgrade 2-advanced/dubbo-sample-autowire zookeeper startup method
upgrade 2-advanced/dubbo-sample-autowire to jdk17 and spring3.2.3

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj closed this Mar 18, 2024
@chickenlj
Copy link
Contributor

duplicate of #1077

@CrazyHZM CrazyHZM reopened this Mar 18, 2024
@kkkjsh
Copy link
Contributor Author

kkkjsh commented Mar 18, 2024

I have resolved the conflicts in 4 files and clicked Mark as resolved.

@chickenlj
Copy link
Contributor

I have resolved the conflicts in 4 files and clicked Mark as resolved.

There are still conflicts. I think maybe the easiest way is to open a new pr based on the latest codebase.

@kkkjsh
Copy link
Contributor Author

kkkjsh commented Mar 18, 2024

ok

There are still conflicts. I think maybe the easiest way is to open a new pr based on the latest codebase.

@chickenlj chickenlj closed this Mar 18, 2024
@kkkjsh kkkjsh deleted the feat/upgrade_autowire_samples branch March 21, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants