Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to springboot 3.2.3 and dubbo 3.3.0-beta.1 #1086

Closed
wants to merge 16 commits into from

Conversation

kwings6
Copy link
Contributor

@kwings6 kwings6 commented Mar 19, 2024

Upgrade to springboot3.2.3 , dubbo 3.3.0-beta.1 and nacos 2.3.1. Modify the project into three modules. Fixed the bug which lead to dubbo cache conflict in local machine.

@kwings6 kwings6 closed this Mar 19, 2024
@kwings6 kwings6 reopened this Mar 19, 2024
@EnableDubbo
public class ProviderApplication {
public static void main(String[] args) {
SpringApplication.run(ProviderApplication.class, args);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add System.out.println("dubbo service started"); here for it's a checking point for the testing framework https://github.com/apache/dubbo-samples/pull/1086/files#diff-162f44ea31c4096aa09a7da9b61f87efeded56aefa1811e8d9a4a1be91bf05f8R41

public static void main(String[] args) {
SpringApplication application = new SpringApplication(ConsumerApplication.class);

//修改dubbo的本地缓存路径,避免本地启动多个应用导致缓存冲突
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please translate to English

qos-port: 20994
protocol:
name: dubbo
port: 20884
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consume does not need protocol configuration, please remove it.

qos-port: 20993
protocol:
name: dubbo
port: 20883
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -96,69 +106,25 @@
</exclusion>
</exclusions>
</dependency>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove dubbo-configcenter-nacos and dubbo-registry-nacos dependency

<artifactId>nacos-client</artifactId>
<version>2.3.1</version>
</dependency>
</dependencies>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use dubbo-nacos-spring-boot-starter instead.

<artifactId>nacos-client</artifactId>
<version>2.3.1</version>
</dependency>
</dependencies>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use dubbo-nacos-spring-boot-starter instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I solve the problems you mentioned but failing checks are still exist. The reason of failing checks is run test timeout .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for this failing checks are the same as in the past

@kwings6 kwings6 closed this Mar 25, 2024
@kwings6 kwings6 reopened this Mar 25, 2024
@kwings6 kwings6 closed this Apr 22, 2024
@kwings6 kwings6 deleted the upgrade-springboot branch April 22, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants