-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to springboot 3.2.3 and dubbo 3.3.0-beta.1 #1086
Conversation
…ules and fixed dubbo cache conflict bug
@EnableDubbo | ||
public class ProviderApplication { | ||
public static void main(String[] args) { | ||
SpringApplication.run(ProviderApplication.class, args); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add System.out.println("dubbo service started");
here for it's a checking point for the testing framework https://github.com/apache/dubbo-samples/pull/1086/files#diff-162f44ea31c4096aa09a7da9b61f87efeded56aefa1811e8d9a4a1be91bf05f8R41
public static void main(String[] args) { | ||
SpringApplication application = new SpringApplication(ConsumerApplication.class); | ||
|
||
//修改dubbo的本地缓存路径,避免本地启动多个应用导致缓存冲突 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please translate to English
qos-port: 20994 | ||
protocol: | ||
name: dubbo | ||
port: 20884 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consume does not need protocol
configuration, please remove it.
qos-port: 20993 | ||
protocol: | ||
name: dubbo | ||
port: 20883 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure this port is the same as the value here https://github.com/apache/dubbo-samples/pull/1086/files#diff-162f44ea31c4096aa09a7da9b61f87efeded56aefa1811e8d9a4a1be91bf05f8R40
Please use 20880
@@ -96,69 +106,25 @@ | |||
</exclusion> | |||
</exclusions> | |||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove dubbo-configcenter-nacos
and dubbo-registry-nacos
dependency
<artifactId>nacos-client</artifactId> | ||
<version>2.3.1</version> | ||
</dependency> | ||
</dependencies> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use dubbo-nacos-spring-boot-starter
instead.
<artifactId>nacos-client</artifactId> | ||
<version>2.3.1</version> | ||
</dependency> | ||
</dependencies> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use dubbo-nacos-spring-boot-starter
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I solve the problems you mentioned but failing checks are still exist. The reason of failing checks is run test timeout .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason for this failing checks are the same as in the past
Upgrade to springboot3.2.3 , dubbo 3.3.0-beta.1 and nacos 2.3.1. Modify the project into three modules. Fixed the bug which lead to dubbo cache conflict in local machine.